Merge branch 'feature/SUPPORT-9164' into develop

This commit is contained in:
Eduard Tihomirov 2025-05-15 12:49:15 +03:00
commit 2af7990a64
4 changed files with 28 additions and 8 deletions

View file

@ -5,4 +5,5 @@ public class SecurityConstants {
public static final String AUTH_TOKEN = "auth_token"; public static final String AUTH_TOKEN = "auth_token";
public static final String AUTH_MARKER = "webbpm.ervu-lkrp-ul"; public static final String AUTH_MARKER = "webbpm.ervu-lkrp-ul";
public static final String PRNS_UUID = "prns_uuid_ul"; public static final String PRNS_UUID = "prns_uuid_ul";
public static final String STICKY_SESSION = "stickysession";
} }

View file

@ -106,10 +106,12 @@ public class EsiaAuthInfoStore {
}); });
} }
public static void validateState(String prnsUUID, String state) { public static void validateState(String prnsUUID, String state, String stickySession) {
List<ExpiringState> states = PRNS_UUID_STATE_MAP.get(prnsUUID); List<ExpiringState> states = PRNS_UUID_STATE_MAP.get(prnsUUID);
if (states == null) { if (states == null) {
throw new EsiaException("State invalid. No state found"); throw new EsiaException(
"State invalid. No state found. PrnsUUID: " + prnsUUID + ". State: " + state
+ ". Sticky session:" + stickySession);
} }
long currentTime = System.currentTimeMillis(); long currentTime = System.currentTimeMillis();
@ -117,13 +119,17 @@ public class EsiaAuthInfoStore {
for (ExpiringState expiringState : states) { for (ExpiringState expiringState : states) {
if (expiringState.getState().equals(state)) { if (expiringState.getState().equals(state)) {
if (expiringState.getExpiryTime() < currentTime) { if (expiringState.getExpiryTime() < currentTime) {
throw new EsiaException("State invalid. State : " + state + " expired at : " + expiringState.getExpiryTime()); throw new EsiaException(
"State invalid. PrnsUUID: " + prnsUUID + ". Sticky session:" + stickySession
+ ". State : " + state + " expired at : " + expiringState.getExpiryTime());
} }
return; return;
} }
statesStringBuilder.append(expiringState.getState(), 0, 8).append(", "); statesStringBuilder.append(expiringState.getState()).append(", ");
} }
throw new EsiaException("State invalid. Backend states :" + statesStringBuilder + " cookie state :" + state); throw new EsiaException(
"State invalid. PrnsUUID: " + prnsUUID + ". Sticky session:" + stickySession
+ ". Backend states :" + statesStringBuilder + " cookie state :" + state);
} }
public static void removeState(String prnsUUID) { public static void removeState(String prnsUUID) {

View file

@ -66,6 +66,7 @@ import ru.cg.webbpm.modules.core.runtime.api.LocalizedException;
import ru.cg.webbpm.modules.core.runtime.api.MessageBundleUtils; import ru.cg.webbpm.modules.core.runtime.api.MessageBundleUtils;
import static ru.micord.ervu.security.SecurityConstants.PRNS_UUID; import static ru.micord.ervu.security.SecurityConstants.PRNS_UUID;
import static ru.micord.ervu.security.SecurityConstants.STICKY_SESSION;
/** /**
* @author Eduard Tihomirov * @author Eduard Tihomirov
@ -126,6 +127,10 @@ public class EsiaAuthService {
String state = signResponse.getState(); String state = signResponse.getState();
String clientSecret = signResponse.getSignature(); String clientSecret = signResponse.getSignature();
EsiaAuthInfoStore.addState(prnsUUID, state, esiaConfig.getEsiaStateCookieLifeTime(), esiaConfig.getEsiaLoginAttemptsCount()); EsiaAuthInfoStore.addState(prnsUUID, state, esiaConfig.getEsiaStateCookieLifeTime(), esiaConfig.getEsiaLoginAttemptsCount());
Cookie stickySession = WebUtils.getCookie(request, STICKY_SESSION);
LOGGER.info("Auth states initialized: PrnsUUID: {}; State: {}; StickySession: {}", prnsUUID, state,
stickySession != null ? stickySession.getValue() : "is null"
);
ResponseCookie prnsCookie = securityHelper.createAccessCookie(PRNS_UUID, prnsUUID) ResponseCookie prnsCookie = securityHelper.createAccessCookie(PRNS_UUID, prnsUUID)
.maxAge(esiaConfig.getEsiaStateCookieLifeTime()) .maxAge(esiaConfig.getEsiaStateCookieLifeTime())
.build(); .build();
@ -604,15 +609,21 @@ public class EsiaAuthService {
private void verifyStateFromCookie(HttpServletRequest request, String state, HttpServletResponse response) { private void verifyStateFromCookie(HttpServletRequest request, String state, HttpServletResponse response) {
Cookie cookie = WebUtils.getCookie(request, PRNS_UUID); Cookie cookie = WebUtils.getCookie(request, PRNS_UUID);
Cookie stickySessionCookie = WebUtils.getCookie(request, STICKY_SESSION);
String stickySession = stickySessionCookie != null ? stickySessionCookie.getValue() : "is null";
if (cookie == null) { if (cookie == null) {
throw new EsiaException("State invalid. Cookie not found"); throw new EsiaException(
"State invalid. Cookie not found. State: " + state + ". Sticky session: " + stickySession);
} }
String prnsUUID = cookie.getValue(); String prnsUUID = cookie.getValue();
try { try {
EsiaAuthInfoStore.validateState(prnsUUID, state); EsiaAuthInfoStore.validateState(prnsUUID, state, stickySession);
} }
finally { finally {
EsiaAuthInfoStore.removeState(prnsUUID); EsiaAuthInfoStore.removeState(prnsUUID);
LOGGER.info(
"Remove all states for prnsUUID: " + prnsUUID + ". State: " + state + ". Sticky session: "
+ stickySession);
securityHelper.clearAccessCookie(response, PRNS_UUID); securityHelper.clearAccessCookie(response, PRNS_UUID);
} }
} }

View file

@ -24,7 +24,6 @@ export abstract class AuthGuard implements CanActivate {
public canActivate(route: ActivatedRouteSnapshot, public canActivate(route: ActivatedRouteSnapshot,
state: RouterStateSnapshot): Observable<boolean> | Promise<boolean> | boolean { state: RouterStateSnapshot): Observable<boolean> | Promise<boolean> | boolean {
this.progressIndicationService.showProgressBar();
let url = new URL(window.location.href); let url = new URL(window.location.href);
if (!AccessChecker.checkBrowser()) { if (!AccessChecker.checkBrowser()) {
this.progressIndicationService.hideProgressBar(); this.progressIndicationService.hideProgressBar();
@ -45,6 +44,9 @@ export abstract class AuthGuard implements CanActivate {
let state = params.get('state'); let state = params.get('state');
let error = params.get('error'); let error = params.get('error');
let errorDescription = params.get('error_description'); let errorDescription = params.get('error_description');
if (code || state || error || errorDescription) {
window.history.replaceState({}, document.title, url.pathname);
}
if (isAccess) { if (isAccess) {
return true; return true;
} }